Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.2.x] c/topic_config: Explicitly initialize non-class fields #23155

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #23149

Since we need a default constructor to keep serde happy.

(cherry picked from commit c75b2b3)
@vbotbuildovich vbotbuildovich added this to the v24.2.x-next milestone Aug 30, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 30, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean cherry pick

@oleiman
Copy link
Member

oleiman commented Aug 30, 2024

/ci-repeat 1
skip-units
skip-rebase
skip-redpanda-build

@oleiman oleiman self-assigned this Aug 30, 2024
@bashtanov
Copy link
Contributor

LGTM. The closed failure issue is duplicated by https://redpandadata.atlassian.net/browse/CORE-2506, which I have reopened because its fix was reverted

bashtanov
bashtanov approved these changes Sep 4, 2024
@piyushredpanda piyushredpanda merged commit 380ddc2 into redpanda-data:v24.2.x Sep 4, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants